Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarifications from the Edgeware team #7

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

thomivy
Copy link

@thomivy thomivy commented Jul 25, 2019

Typos, clarity, and language modifications

Typos, clarity, and language modicfications
the lockdrop and centralizes the initial distribution. To ensure a balanced token model that is
both legitimate and inclusive of both lockdrop and signal participants, a number of distribution
improvements have been made prior to genesis.
the design of signalling in the EEdgeware lockdrop leads to many edge conditions that may hamper the optimal
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Typo: "EEdgeware"


1. Remove Signalling on Behalf of Contracts

2. Remove Generalized Locking

3. All signalled funds distributed in genesis
3. All token allocations to signallers distributed fully at genesis.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Typo: Extra space between 3. and All

@@ -54,33 +53,34 @@ en:
msg.value greater than 0 for the entirety of the 3, 6 or 12-month lock durations”,
and in these cases “that signal can be treated as a lock for the purposes of the allocation award”.

By removing the ability to signal on behalf of a contract, Straightedge has solved for Generalized
Locks and other edge case vulnerabilities. However, it is still worth explicitly pointing out some
By removing the ability to signal on behalf of a contract, Straightedge has ntended to reduce vulnerabilities by
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Typo: "ntended"

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The point here was to say that, we that generalized locks are a moot point given that we "signalling on behalf of a contract" is removed. However, we want to share some reasons why the generalized lock is especially harmful, even more so than a normal "contract signal".

of the issues with the policy. First, it places undue burden upon the launchers of the network to
audit and decide on different generalized lock contracts, which may contain edge cases such as
bypassing locking by issuing derivatives of the locked Ether (such as with WETH). Further, if a
contract does not correctly lock, or if code claiming to be a lock bypasses detection through
underhanded Solidity techniques, it could break the legitimacy of the initial distribution of
the entire network. Removing generalized locking removes the necessity for case-by-case decision-making
by a launch-team, and other edge case vulnerabilities.
the entire network. While Edgeware’s contract codes have been fully audited by Quantstamp, Removing generalized
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Typo: unnecessary extra space between Quantstamp, and Removing

Typo: Removing should be without capital.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The Commonwealth-written contracts aren't relevant to this point. It's about new generalized lock contracts. Is Quantstamp going to audit all of those?

provide a substantial voting-percentage of all network-tokens to a party or parties not in control
of the funds for which tokens are rewarded.
provide favor to several small, select group of individuals and teams. While the changes were disclosed before the
lockdrop began The result would provide an estimated 9% substantial voting-percentage of all network-tokens to a
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Typo: "began The result" doesn't need a capital T

Challenge: how is this 9% calculated?

Copy link

@sunnya97 sunnya97 Jul 28, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

how is this 9% calculated?

++ @thomivy

Please review the Edgeware FAQs where you can learn more about the lockdrop contracts,
the Straightedge software, and incentives for validation.
Since Straightedge is a new project and a fork, we rely upon the efforts of the Edgeware developers for our
documentatione At their site, https://edgewa.re, you can review the Edgeware FAQs where you can learn more about the
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Typo: "documentatione At their site" - documentation doesn't need an extra e, and At doesn't need capital A

@@ -54,33 +53,34 @@ en:
msg.value greater than 0 for the entirety of the 3, 6 or 12-month lock durations”,
and in these cases “that signal can be treated as a lock for the purposes of the allocation award”.

By removing the ability to signal on behalf of a contract, Straightedge has solved for Generalized

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
By removing the ability to signal on behalf of a contract, Straightedge has solved for Generalized
By removing the ability to signal on behalf of a contract, Straightedge has already removed the Generalized


1. Remove Signalling on Behalf of Contracts

2. Remove Generalized Locking

3. All signalled funds distributed in genesis
3. All token allocations to signallers distributed fully at genesis.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
3. All token allocations to signallers distributed fully at genesis.
3. All token allocations to signallers distributed fully at genesis.

@@ -115,14 +115,16 @@ en:

- question: How are STR tokens distributed?
answer: |
Lockdrop and signal participants will receive 90% of STR tokens, with the exception of contributions
through signalling on behalf of a contract. The remaining 10% of distribution will be allocated as
The proportions of the Straightedge genesis block distribution mirror the proportions of Edgeware Lockdrop and

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
The proportions of the Straightedge genesis block distribution mirror the proportions of Edgeware Lockdrop and
The proportions of the Straightedge genesis block distribution mirror the proportions of Edgeware Lockdrop in which

Lockdrop and signal participants will receive 90% of STR tokens, with the exception of contributions
through signalling on behalf of a contract. The remaining 10% of distribution will be allocated as
The proportions of the Straightedge genesis block distribution mirror the proportions of Edgeware Lockdrop and
signal participants will receive 90% of STR tokens, with the exception of contributions

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
signal participants will receive 90% of STR tokens, with the exception of contributions
lock and signal participants will receive 90% of STR tokens, with the exception of contributions

a founders’ reward to entities contributing to the launch of the Straightedge project.

- question: What if I want to learn more about the lockdrop or technical details?
answer: |
Please review the Edgeware FAQs where you can learn more about the lockdrop contracts,
the Straightedge software, and incentives for validation.
Since Straightedge is a new project and a fork, we rely upon the efforts of the Edgeware developers for our

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Since Straightedge is a new project and a fork, we rely upon the efforts of the Edgeware developers for our
As the Straightedge lockdrop is the same process as the Edgeware lockdrop, we recommend checking out the documentation written by the Edgeware development team

Please review the Edgeware FAQs where you can learn more about the lockdrop contracts,
the Straightedge software, and incentives for validation.
Since Straightedge is a new project and a fork, we rely upon the efforts of the Edgeware developers for our
documentatione At their site, https://edgewa.re, you can review the Edgeware FAQs where you can learn more about the

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
documentatione At their site, https://edgewa.re, you can review the Edgeware FAQs where you can learn more about the
available on their website, https://edgewa.re. There you can review the Edgeware FAQs where you can learn more about the

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants